Please see my post in the other thread re “URL encoding characters”. The handler you’re using will not work for non-Latin1 encodings. Given that the Net is now mostly Unicode, it’ll fail with a lot of input (notably the diverse Asian scripts).
If you can live with JavaScript, I suggest this script, closely modelled after yours. Just a bit shorter and working correctly with Unicode selections.
(() => {
const app = Application("DEVONthink 3");
app.includeStandardAdditions = true;
const frontWindow = app.thinkWindows[0];
const record = frontWindow.contentRecord;
const itemLink = `x-devonthink-item://${record.uuid()}`;
const selectedText = frontWindow.selectedText();
const searchParameter = `?search=${encodeURIComponent(selectedText)}`;
app.setTheClipboardTo(itemLink + searchParameter);
})()
Alternatively, one could use NSString methods and the AppleScript-ObjC bridge to do the conversion correctly. Which also will result in a shorter script.
Found that on StackExchange:
on urlEncode(input)
tell current application's NSString to set rawUrl to stringWithString_(input)
set theEncodedURL to rawUrl's stringByAddingPercentEscapesUsingEncoding:4 -- 4 is NSUTF8StringEncoding
return theEncodedURL as Unicode text
end urlEncode